Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] pos_event_sale: Migration 16.0 #1022

Open
wants to merge 49 commits into
base: 16.0
Choose a base branch
from

Conversation

BT-dmoreno
Copy link

No description provided.

ivantodorovich and others added 30 commits July 4, 2023 14:14
By default, the longPressDelay is 1000ms which is not intuitive
and makes it pretty much unusable in touchscreen devices.

In this case, it makes no sense to have a delay for selecting dates.
By setting it to 0 we're effectively disabling the pressDelay, and
the user experience is much better.
* Print event.registration receipts.
* Refunding a pos.order will cancel the event registrations.
* Support pricelists.
* Refactored code for better overrideability.
This allows to play nice with other modules, that may either be:

* Trying to modify the created registrations
* Creating registrations themselves
* Or even calling `_create_event_registrations` programatically.

It has no impact on functionality, though.
There was a typo on the xml view, having it not rendering properly.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-15.0/pos-15.0-pos_event_sale
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/
Currently translated at 100.0% (69 of 69 strings)

Translation: pos-15.0/pos-15.0-pos_event_sale
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/it/
It helps understand the difference between `getSeatsAvailable` and
`getSeatsAvailableReal`. Moreover it helps with the module extensibility.
Currently translated at 100.0% (69 of 69 strings)

Translation: pos-15.0/pos-15.0-pos_event_sale
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/it/
… pos_order_line before installation

This helps to avoid a Memory Error when installing this module on an instance with a big amount of existing pos_order_line
Camille0907 and others added 9 commits July 4, 2023 14:14
EventEventTicket inherits from EventTypeTicket, so we don't need to duplicate the field declaration, if it is the same in both module. This ease overriding, as we need to override only one model, if we expect the same behavior in both.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-15.0/pos-15.0-pos_event_sale
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/
Currently translated at 100.0% (73 of 73 strings)

Translation: pos-15.0/pos-15.0-pos_event_sale
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/it/
@legalsylvain
Copy link
Contributor

/ocabot migration pos_event_sale

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 5, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 5, 2023
37 tasks
@BT-dmoreno BT-dmoreno marked this pull request as draft July 5, 2023 12:17
@BT-dmoreno BT-dmoreno marked this pull request as ready for review July 6, 2023 07:06
@ivantodorovich
Copy link
Contributor

Hey @BT-dmoreno , thanks for migrating this module!

I haven't done a full review yet, though.. could you squash (all or some of) your migration commits into [16.0][MIG] pos_event_sale: Migration to 16.0 ?

I see some noise in them, like: [IMP] Remove non-used variable is patching code introduced in [IMP] Prevent race condition on payment screen validate button, you might as well squash them.

Ideally, keep only [16.0][MIG] pos_event_sale: Migration to 16.0 along with some totally optional and well described extra commits 🙏🏻

@BT-dmoreno
Copy link
Author

Hi @ivantodorovich thanks for your comment! Finally I got some time to apply your suggestion, I have squashed all my last commits into a single one, it should be fine now.

@ivantodorovich
Copy link
Contributor

Thanks @BT-dmoreno !

It looks like test tours are failing, could you check?

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@maq-adhoc
Copy link

@BT-dmoreno How are you?
Can I help you with this migration? If not I can continue your work in another PR.
I understand that you are close to finish it.

@BT-dmoreno
Copy link
Author

@maq-adhoc I have not time at the moment to continue with this module. Yes, feel free to continue it yourself please.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 9, 2024
@maq-adhoc
Copy link

@maq-adhoc I have not time at the moment to continue with this module. Yes, feel free to continue it yourself please.

im start work in #1205

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants