-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] pos_event_sale: Migration 16.0 #1022
base: 16.0
Are you sure you want to change the base?
Conversation
By default, the longPressDelay is 1000ms which is not intuitive and makes it pretty much unusable in touchscreen devices. In this case, it makes no sense to have a delay for selecting dates. By setting it to 0 we're effectively disabling the pressDelay, and the user experience is much better.
* Print event.registration receipts. * Refunding a pos.order will cancel the event registrations. * Support pricelists. * Refactored code for better overrideability.
This allows to play nice with other modules, that may either be: * Trying to modify the created registrations * Creating registrations themselves * Or even calling `_create_event_registrations` programatically. It has no impact on functionality, though.
There was a typo on the xml view, having it not rendering properly.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-15.0/pos-15.0-pos_event_sale Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/
Currently translated at 100.0% (69 of 69 strings) Translation: pos-15.0/pos-15.0-pos_event_sale Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/it/
It helps understand the difference between `getSeatsAvailable` and `getSeatsAvailableReal`. Moreover it helps with the module extensibility.
Currently translated at 100.0% (69 of 69 strings) Translation: pos-15.0/pos-15.0-pos_event_sale Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/it/
… pos_order_line before installation This helps to avoid a Memory Error when installing this module on an instance with a big amount of existing pos_order_line
EventEventTicket inherits from EventTypeTicket, so we don't need to duplicate the field declaration, if it is the same in both module. This ease overriding, as we need to override only one model, if we expect the same behavior in both.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-15.0/pos-15.0-pos_event_sale Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/
Currently translated at 100.0% (73 of 73 strings) Translation: pos-15.0/pos-15.0-pos_event_sale Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_event_sale/it/
/ocabot migration pos_event_sale |
7ad59eb
to
fad2db1
Compare
Hey @BT-dmoreno , thanks for migrating this module! I haven't done a full review yet, though.. could you squash (all or some of) your migration commits into I see some noise in them, like: Ideally, keep only |
704c45a
to
e8d89b1
Compare
Hi @ivantodorovich thanks for your comment! Finally I got some time to apply your suggestion, I have squashed all my last commits into a single one, it should be fine now. |
Thanks @BT-dmoreno ! It looks like test tours are failing, could you check? |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@BT-dmoreno How are you? |
@maq-adhoc I have not time at the moment to continue with this module. Yes, feel free to continue it yourself please. |
im start work in #1205 |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
No description provided.